This repository was archived by the owner on Apr 28, 2026. It is now read-only.
flake: break cyclic dependencies to avoid inflating flake.lock#202
Merged
Merged
Conversation
phip1611
approved these changes
Apr 15, 2026
phip1611
left a comment
phip1611
left a comment
Member
There was a problem hiding this comment.
In the long run, the flakes should be restructured to avoid the cyclic dependency,
The cyclic dependency is really not nice, I agree. Thanks for the quick fix with the pragmatic solution!
arctic-alpaca
force-pushed
the
cyclic-deps
branch
from
a398a2d to
91fe077
Compare
hertrste
approved these changes
Apr 15, 2026
scholzp
approved these changes
Apr 16, 2026
On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
arctic-alpaca
force-pushed
the
cyclic-deps
branch
from
91fe077 to
e333378
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the long run, the flakes should be restructured to avoid the cyclic dependency, but for now this should reduce the
flake.lockbloat.Libvirt CI: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/173